[CodeExtractor][AMDGPU] Improve debug info for input values.#2179
Open
abidh wants to merge 1 commit intoamd-stagingfrom
Open
[CodeExtractor][AMDGPU] Improve debug info for input values.#2179abidh wants to merge 1 commit intoamd-stagingfrom
abidh wants to merge 1 commit intoamd-stagingfrom
Conversation
5843069 ("[CodeExtractor] Improve debug info for input values. (llvm#136016)") extended fixupDebugInfoPostExtraction so outlined inputs could keep or regain dbg.declare / dbg.value by walking debug uses of each extracted input and materializing records in the child function. On AMDGPU, OpenMP target outlining (FixupDebugInfoForOutlinedFunction) can leave those records on the addrspace(5) alloca behind an addrspacecast/store/load chain while CodeExtractor still lists the load as the promoted input. In that case findDbgUsers(load) sees nothing even though the variable is still described in the parent. - If the triple is AMDGPU and the input is a load whose pointer operand is ultimately an alloca, also search for debug users on that alloca and use it as the location value when updating or cloning records. - For AMDGPU, add DIOP based expressions.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5843069 ("[CodeExtractor] Improve debug info for input values. (llvm#136016)") extended fixupDebugInfoPostExtraction so outlined inputs could keep or regain dbg.declare / dbg.value by walking debug uses of each extracted input and materializing records in the child function.
On AMDGPU, OpenMP target outlining (FixupDebugInfoForOutlinedFunction) can leave those records on the alloca behind an addrspacecast/store/load chain while CodeExtractor still lists the load as the promoted input. In that case findDbgUsers(load) sees nothing even though the variable is still described in the parent.
This PR does 2 things:
If the triple is AMDGPU and the input is a load whose pointer operand is ultimately an alloca, also search for debug users on that alloca and use it as the location value when updating or cloning records.
For AMDGPU, add DI-Op based expressions.