feat: Update orchestration specification#1646
feat: Update orchestration specification#1646github-actions[bot] wants to merge 18 commits intomainfrom
Conversation
…tion/rel-0.115.19
| parameters: | ||
| - $ref: '#/components/parameters/AIResourceGroup' | ||
| - $ref: '#/components/parameters/AIObjectStoreSecretName' |
There was a problem hiding this comment.
[req] Could you please sample code, which showcases how these headers can be passed to the chat completion end point?
Would be interesting to know how feedback service specific values are used by the orchestration service.
There was a problem hiding this comment.
I added something that should match how it's supposed to be used, but I haven't executed it. Do we have a usable object store for e2e tests?
There was a problem hiding this comment.
We don't I think, should we just add these headers to the JSDoc of the client instead then?
There was a problem hiding this comment.
I also don't understand from the comment what these headers are supposed to do.
Does feedback service create these secrets?
@ChristophMatthies What are the AIResourceGroup and AIObjectStoreSecretName headers used for? They seem to belong with the feedback service. How are these fields used with the orchestration service?
There was a problem hiding this comment.
I removed the sample-code and added additional jsdoc and types. As far as I can tell evaluation metrics will be pushed to the object store specified in the header.
|
Why are the checks in this PR stuck? |
Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
Seems to work now maybe GitHub was stuck again. |
davidkna-sap
force-pushed
the
spec-update/orchestration/rel-0.115.19
branch
from
5826519 to
d877bf0
Compare
…tion/rel-0.115.19
KavithaSiva
left a comment
KavithaSiva
left a comment
There was a problem hiding this comment.
Could you please also add a test for AI-Object-Store-Secret-Name being passed through to the HTTP request headers.
Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
3 participants
Context
Update orchestration specification file based on rel-0.115.19.
This PR was created automatically by the spec-update workflow.
You can commit on top of this branch, but as long as this PR is open the action can't be re-run.
Before merging, make sure to update tests and release notes, if necessary.
Definition of Done