Open
Conversation
Contributor
Merge Checks Failed |
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
CXSPA-11392
|
| Run status |
|
| Run duration | 04m 12s |
| Commit |
|
| Committer | Roman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
3
|
|
|
0
|
|
|
0
|
|
|
101
|
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
reviewed
Apr 1, 2026
Contributor
Pio-Bar
left a comment
There was a problem hiding this comment.
Changes look good to me. I've tested the ConsentDialogComponent and the focus stays on checkboxes after toggling. It is not lost after the success message is closed. The Screen reader output seems consistent as well.
However, I see the original ticket concerned the ConsentManagementComponent not the dialog. When testing on /my-account/consents the focus is lost after toggling the checkboxes. The component re-renders causing the focus to default to the body element. Is this in the scope of the ticket?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-11392
QA steps:
Checkbox focus retained on toggle
Expected: Focus remains on the same checkbox. A success message appears but does not steal focus.
Press Space again to un-toggle
Expected: Focus still remains on the same checkbox.
Message close restores focus
Expected: Focus returns to the previously toggled checkbox