Skip to content

fix: Display Select a value message for SINGLE_SELECTION_IMAGE UI type (CXSPA-12506) #21310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Larisa-Staroverova wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix: Display Select a value message for SINGLE_SELECTION_IMAGE UI type (CXSPA-12506) #21310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,6 +1269,16 @@ describe('OccConfiguratorVariantNormalizer', () => {
expect(attributeSSIWithValues.incomplete).toBe(false);
});

it('should set incomplete by single-selection-image type with retract option correctly', () => {
attributeSSIWithValues.selectedSingleValue =
Configurator.RetractValueCode;
occConfiguratorVariantNormalizer.compileAttributeIncomplete(
attributeSSIWithValues
);

expect(attributeSSIWithValues.incomplete).toBe(true);
});

it('should set incomplete by checkbox type correctly', () => {
occConfiguratorVariantNormalizer.compileAttributeIncomplete(
attributeCheckboxWOValue
Expand Down
11 changes: 2 additions & 9 deletions ...duct-configurator/rulebased/occ/variant/converters/occ-configurator-variant-normalizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ export class OccConfiguratorVariantNormalizer
Configurator.UiType.RADIOBUTTON_ADDITIONAL_INPUT,
Configurator.UiType.DROPDOWN_ADDITIONAL_INPUT,
Configurator.UiType.DROPDOWN,
Configurator.UiType.SINGLE_SELECTION_IMAGE,
];
const inputTypes = [
Configurator.UiType.NUMERIC,
Expand All @@ -554,8 +555,6 @@ export class OccConfiguratorVariantNormalizer
const uiType = attribute.uiType ?? Configurator.UiType.NOT_IMPLEMENTED;
if (singleValueTypes.includes(uiType)) {
this.compileAttributeIncompleteSingleLevel(attribute);
} else if (uiType === Configurator.UiType.SINGLE_SELECTION_IMAGE) {
this.compileAttributeIncompleteSingleSelectionImage(attribute);
} else if (inputTypes.includes(uiType)) {
this.compileAttributeIncompleteInputTypes(attribute);
} else if (multiValueTypes.includes(uiType)) {
Expand All @@ -573,13 +572,7 @@ export class OccConfiguratorVariantNormalizer
attribute.incomplete = true;
}
}
protected compileAttributeIncompleteSingleSelectionImage(
attribute: Configurator.Attribute
): void {
if (!attribute.selectedSingleValue) {
attribute.incomplete = true;
}
}

protected compileAttributeIncompleteInputTypes(
attribute: Configurator.Attribute
): void {
Expand Down
Loading