fix: replace deprecated YYYY with yyyy in date pipe for Angular 19 compatibility#21330
Open
savoiadiego wants to merge 1 commit intoSAP:developfrom
Open
fix: replace deprecated YYYY with yyyy in date pipe for Angular 19 compatibility#21330savoiadiego wants to merge 1 commit intoSAP:developfrom
savoiadiego wants to merge 1 commit intoSAP:developfrom
Conversation
…mpatibility Angular 19 enforces stricter validation of date format tokens in DatePipe, aligning with the Unicode Date Field Symbol Specification. The token 'YYYY' (week-based year) is no longer accepted in this context and can lead to runtime errors. It has been replaced with 'yyyy' (calendar year), which is the correct format for all existing use cases in Spartacus. This change ensures compatibility with Angular 19 and prevents incorrect year formatting around ISO week boundaries.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular 19 enforces stricter validation of date format tokens in DatePipe, aligning with the Unicode Date Field Symbol Specification.
The token 'YYYY' (week-based year) is no longer accepted in this context and can lead to runtime errors. It has been replaced with 'yyyy' (calendar year), which is the correct format for all existing use cases in Spartacus.
This change ensures compatibility with Angular 19 and prevents incorrect year formatting around ISO week boundaries.