fix(ci): add cargoWorkspacePath to cargo-workspace plugin#58
Draft
fix(ci): add cargoWorkspacePath to cargo-workspace plugin#58
Conversation
PR SummaryLow Risk Overview Written by Cursor Bugbot for commit 08f0ca1. This will update automatically on new commits. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 08f0ca1 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
force-pushed
the
fix/release-please-config
branch
from
537ac26 to
8a7a0f5
Compare
yordis
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| }, | ||
| { | ||
| "type": "cargo-workspace", | ||
| "cargoWorkspacePath": "rsworkspace", |
There was a problem hiding this comment.
Unsupported config option added instead of removing plugin
High Severity
The PR title and description say to remove the cargo-workspace plugin, but the actual change keeps the plugin and adds a cargoWorkspacePath option. The PR description itself states that upstream PR googleapis/release-please#2682 (which adds cargoWorkspacePath support) is "open PR, not yet merged." This means release-please won't recognize the cargoWorkspacePath option, and the workflow will likely still fail with the same Failed to find file: Cargo.toml error.
yordis
changed the title
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
fix/release-please-config
branch
from
8a7a0f5 to
08f0ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargoWorkspacePath: "rsworkspace"to thecargo-workspaceplugin so release-please finds the workspaceCargo.tomlatrsworkspace/Cargo.tomlinstead of the repo rootContext
The
cargo-workspaceplugin hardcodesCargo.tomllookup at the repo root. Our workspace lives atrsworkspace/, causingFailed to find file: Cargo.toml. ThecargoWorkspacePathoption is being added upstream to fix this.Related upstream
cargoWorkspacePathoption (open PR)Test plan