Open
Conversation
fire
changed the title
fire
reviewed
Nov 19, 2025
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
When we merge can you squash to one commit?
Ughuuu
force-pushed
the
build-and-deploy-docker-to-ghcr
branch
from
eaaa8e3 to
4fc0bec
Compare
Member
|
Can you try a more readable github commit message? Like:
Maybe a bit more summarized. |
Ughuuu
force-pushed
the
build-and-deploy-docker-to-ghcr
branch
from
aa1c741 to
c62611a
Compare
update gitignore only do frontend build on master branch push only on main remove extra } use arm host on arm build add comment try with +JPperf true disable cache build and push frontend remove cached stuff disable job cancelling upd use separate step for arch separate in 2 jobs fix for arm64 to install openssl and ca-certs fix warnings upd to only build for PR fix docker warnings also push uro-frontend build both arm64 and amd64 only push on master test pushing fix lower case Add also linting job for frontend. Update lint.yml
Ughuuu
force-pushed
the
build-and-deploy-docker-to-ghcr
branch
from
c62611a to
a60a76f
Compare
Member
|
The credo lint can be turned into an ignore so it passes but still outputs. The code doesn't have compile errors as far as I can see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.