Button: Remove obsolete Safari + VoiceOver workaround#77107
Merged
Conversation
|
Size Change: -61 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
mirka
commented
Apr 7, 2026
|
|
||
| ### Bug Fixes | ||
|
|
||
| <<<<<<< fix/rtc-inline-inserter |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 7cc643b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24094770338
|
Mamaduka
approved these changes
Apr 8, 2026
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Nice!
There is also a h5bp/main.css#12 (comment) from 2023 that the issue no longer reproduces, and I'm unable to reproduce today either, in all three major browsers.
I recently re-tested some macOS-specific a11y issues, and it seems they fixed a bunch of them. It feels great to remove similar hacks. Let's close the report as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes an old Button-specific Safari + VoiceOver workaround for visually hidden text.
Why?
Originally introduced in #13221, this workaround appears to be obsolete now.
Buttonno longer renders itsVisuallyHiddendescription content inside.components-button, so the old.components-button .components-visually-hidden { height: auto; }rule no longer applies. This has been this way for at least five years, possibly more. (Note: The class name isn't set in the component file, but comes from the context system. You should indeed see it in the rendered HTML.)There is also a report from 2023 that the issue no longer reproduces, and I'm unable to reproduce today either, in all three major browsers.
Testing Instructions
npm run storybook:dev.Buttonstories.descriptionfrom the controls, and check the VoiceOver behavior.Use of AI Tools
GPT 5.4 High was used to help investigate the history of the workaround and draft this PR description.