Skip to content

RadioControl: add support for disabling radio group #77127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 13 commits into from
Apr 9, 2026
Merged

RadioControl: add support for disabling radio group #77127

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3d23e9f
Add disabled styles (and storybook control) for radiocontrol
oandregal Apr 8, 2026
b9b22f1
Remove git conflicts markers from changelog
oandregal Apr 8, 2026
c44ff56
Add changelog entry
oandregal Apr 8, 2026
bd3438a
Fix disabled styles
mirka Apr 9, 2026
5cb9fc6
Remove unnecessary class
mirka Apr 9, 2026
2aa3ed4
Clarify prop description
mirka Apr 9, 2026
2bb420d
Clarify changelog
mirka Apr 9, 2026
0b17487
Remove unnecessary Storybook config
mirka Apr 9, 2026
89e49a4
Add unit test
mirka Apr 9, 2026
a04cf0b
Merge trunk
mirka Apr 9, 2026
cecd128
Merge branch 'trunk' into fix/disabled-styles-radio
mirka Apr 9, 2026
3726f1d
Add defense styles for forms.css
mirka Apr 9, 2026
9965730
Merge branch 'trunk' into fix/disabled-styles-radio
oandregal Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Bug Fixes

- `RadioControl`: Add support for disabled radio group [#77127](https://github.com/WordPress/gutenberg/pull/77127).
- `Textarea`: Fix disabled styles [#77129](https://github.com/WordPress/gutenberg/pull/77129).
- `Autocomplete`: Fix value comparison to avoid resetting block inserter in RTC ([#76980](https://github.com/WordPress/gutenberg/pull/76980)).
- `ValidatedRangeControl`: Fix `aria-label` rendered as `[object Object]` when `required` or `markWhenOptional` is set ([#77042](https://github.com/WordPress/gutenberg/pull/77042)).
Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/radio-control/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export function RadioControl(
onChange,
onClick,
hideLabelFromVision,
disabled,
options = [],
id: preferredId,
...additionalProps
Expand All @@ -89,6 +90,7 @@ export function RadioControl(
id={ id }
role="radiogroup"
className={ clsx( className, 'components-radio-control' ) }
disabled={ disabled }
aria-describedby={ !! help ? generateHelpId( id ) : undefined }
Comment on lines 88 to 94
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR introduces a new disabled prop/state (fieldset disabled + .is-disabled styling), but the existing RadioControl test suite doesn’t cover disabled behavior. Please add tests to verify radios are disabled (and onChange isn’t called) when disabled is true, including mouse click and keyboard interaction paths.

Copilot uses AI. Check for mistakes.
>
{ hideLabelFromVision ? (
Expand Down
23 changes: 21 additions & 2 deletions packages/components/src/radio-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

font-family: $default-font;
font-size: $default-font-size;

}

.components-radio-control__group-wrapper.has-help {
Expand All @@ -34,7 +35,10 @@
margin: 0;
padding: 0;
appearance: none;
cursor: pointer;

&:not(:disabled) {
cursor: pointer;
}

&:focus {
@include button-style-outset__focus(var(--wp-admin-theme-color));
Expand All @@ -49,13 +53,28 @@
border-radius: $radius-round;
}
}

&:disabled {
background: $components-color-gray-100;
border: 1px solid $components-color-gray-300;
opacity: 1; // Override style from wp-admin forms.css.

&:checked::before {
border-color: $components-color-gray-300;
opacity: 1; // Override style from wp-admin forms.css.

}
}
}

.components-radio-control__label {
grid-column: 2;
grid-row: 1;

cursor: pointer;
.components-radio-control:not(:disabled) & {
cursor: pointer;
}

line-height: $radio-input-size-sm;

@include break-small() {
Expand Down
10 changes: 10 additions & 0 deletions packages/components/src/radio-control/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,16 @@ describe.each( [
).toBeVisible();
} );

it( 'should disable the radio group when `disabled` is true', () => {
render(
<Component { ...defaultProps } disabled onChange={ () => {} } />
);

expect(
screen.getByRole( 'radiogroup', { name: defaultProps.label } )
).toBeDisabled();
} );

it( 'should describe the radio group with the help text', () => {
const onChangeSpy = jest.fn();
render(
Expand Down
6 changes: 6 additions & 0 deletions packages/components/src/radio-control/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ export type RadioControlProps = Pick<
BaseControlProps,
'label' | 'help' | 'hideLabelFromVision'
> & {
/**
* Whether the radio group should be disabled.
*
* @default false
*/
disabled?: boolean;
/**
* A function that receives the value of the new option that is being
* selected as input.
Expand Down
Loading