Open
Conversation
oandregal
requested review from
a team,
ajitbohra,
gigitux and
ntsekouras
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Components
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses missing disabled-state visuals for CheckboxControl so a checked+disabled checkbox no longer appears identical to an enabled checkbox (notably in DataForm Storybook scenarios). It adds disabled styling at the component stylesheet level and tweaks a DataForm story to display both boolean control variants together.
Changes:
- Add
:disabled-driven styling toCheckboxControl(opacity + cursor adjustments), including dimming the checkmark icon uniformly. - Update the DataForm “Layout Regular” story to render
can_commentas a toggle and place it next to thestickyboolean field for easier visual comparison.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/checkbox-control/style.scss | Adds disabled-state cursor handling and dims the entire input container (including SVG icons) when the checkbox input is disabled. |
| packages/dataviews/src/dataform/stories/layout-regular.tsx | Adjusts the boolean field presentation/order in Storybook to show both checkbox and toggle variants together. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Size Change: +119 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in 52558bb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24128137087
|
Member
Author
|
There's this conversation about whether we go this route or another that's important to figure out for this PR to land: #77127 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #77090
What?
Add disabled styles for the
CheckboxControlcomponent.Why?
The
CheckboxControlcomponent had no CSS styles for the:disabledstate. When a checkbox was both checked and disabled, the blue accent background ($components-color-accent) rendered at full opacity, making it visually indistinguishable from an enabled checkbox.This was visible in the DataForm field types boolean story where setting
disabled: truehad no visual effect on the checkbox.How?
:disabledstyles topackages/components/src/checkbox-control/style.scss:opacity: 0.3on.components-checkbox-control__input-container:has(:disabled)to dim both the custom-styled input and the absolutely-positioned SVG checkmark icon uniformly — matching the toggle's disabled opacity.cursor: defaulton the disabled input and on the label (via.components-checkbox-control:has(:disabled)).Edit: 'toggle'for thecan_commentfield and moved it next to thestickycheckbox so both boolean control variants are visible together.Testing Instructions
npm run storybook.True.Use of AI Tools
Claude Code was used to assist with identifying the root cause and implementing the fix.