Separator Block: Apply default block variation when inserting via --- shortcut#77135
Open
BugReportOnWeb wants to merge 1 commit intoWordPress:trunkfrom
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #75259
Apply default block variation attributes when creating a Separator block via the
---markdown shortcut.Why?
When a default block variation is registered for the Separator block, it is correctly applied when inserting via the block inserter UI. But when inserting via the
---shortcut, it creates the Separator block with no attributes, so the default variation is never used and the block falls back to its hardcoded defaults.How?
Updated the
inputtransform to check the registered default variation for the Separator block before callingcreateBlock, and merge its attributes in.If no default variation is registered,
attributesfalls back to an empty object andcreateBlockbehaves exactly as before with no registered default variation.Testing Instructions
tagName: 'div'(could use the snippet from the issue)div---to insert a Separator. Before the fix it useshr, after the fix it correctly usesdiv.hrbehaviour.Screenshots or screencast