Skip to content

fix: Numeric value clearing in preset input controls #77139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 3 commits into from
Apr 10, 2026
+80 −4
Merged

fix: Numeric value clearing in preset input controls #77139

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc7384
fix: input control clear empty numeric value
DarkMatter-999 Apr 8, 2026
bebc65e
fix: simplify logic and prevent undefined values from getting saved
DarkMatter-999 Apr 9, 2026
bcd7b64
test: add tests for number input clear behavior (#77124)
DarkMatter-999 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/block-editor/src/components/preset-input-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,18 @@ export default function PresetInputControl( {
unitConfig?.max ?? customValueSettings[ computedUnit ]?.max ?? 10;

const handleCustomValueChange = ( newValue ) => {
const isNumeric = ! isNaN( parseFloat( newValue ) );
const newCustomValue = isNumeric ? newValue : undefined;
const isExplicitlyEmpty = newValue === '';
const isNumeric =
newValue !== undefined && ! isNaN( parseFloat( newValue ) );

let newCustomValue;
if ( isExplicitlyEmpty ) {
newCustomValue = '';
Copy link
Copy Markdown
Contributor

@aaronrobertshaw aaronrobertshaw Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing this through to onChange will result in empty string values in the block attributes persisted in the block comment delimiter. It would be best if we can fix this bug without doing this.

} else if ( isNumeric ) {
newCustomValue = newValue;
} else {
newCustomValue = undefined;
}

if ( newCustomValue !== undefined ) {
onChange( newCustomValue );
Expand Down
Loading