Conversation
|
Size Change: 0 B Total Size: 7.74 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8081a39. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24130257720
|
aduth
approved these changes
Apr 8, 2026
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM and good to get ahead of 👍 When I introduced this, I think I wasn't sure we'd have a use-case for .module.scss if new stylesheets would be preferring theme variables over @wordpress/base-styles and maybe just wanting to move away from Sass in general. I suppose there's a case for things like gap in support (e.g. responsive) and migrating existing stylesheets. Maybe Sass utilities are helpful too.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Broadens the root
.stylelintrc.jsCSS moduleoverridesglob from**/*.module.cssto**/*.module.{css,scss}so the same rules apply to SCSS CSS modules.Why?
*.module.scssfiles were already picked up bynpm run lint:cssvia**/*.scss, but they did not match the CSS module override block. That meant rules such asproperty-no-unknown(forcomposes),declaration-property-max-values, and the logical-properties plugin were not applied consistently between.module.cssand.module.scss.Testing Instructions
npm run lint:css