-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Toolbar: Add access+w keyboard shortcut to toggle toolbar on frontend #11456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apermo
wants to merge
4
commits into
WordPress:trunk
Choose a base branch
from
apermo:feature/toolbar-toggle-shortcut
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
009ae39
feat(toolbar): add keyboard shortcut to toggle toolbar visibility
apermo 6034341
chore(toolbar): change (at)since to TBD
apermo 0acc2d5
refactor(toolbar): use Ctrl+Shift+F shortcut
apermo 51960f3
Merge branch 'trunk' into feature/toolbar-toggle-shortcut
apermo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
! importantneed here?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The admin bar "bump" styles — which push the page content down to make room for the toolbar — are added as inline CSS via
wp_enqueue_admin_bar_bump_styles()inadmin-bar.phpwordpress-develop/src/wp-includes/admin-bar.php
Lines 1285 to 1310 in 074792e
That rule uses
!important.Our override:
needs
!importanttoo, otherwise the bump style's!importantwould always win regardless of our higher specificity (html.wp-toolbar-hidden>html). With both using!important, our selector wins because it's more specific — which is exactly what we want.