Skip to content

[Website] Add custom error message when artifact is expired #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanJakes merged 2 commits into from
Apr 8, 2026
+9 −3
Merged

[Website] Add custom error message when artifact is expired #3453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
668f971
Add custom error message when artifact is expired
mho22 Apr 1, 2026
d83c28e
Fix typo: "fill an issue" → "file an issue"
JanJakes Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/playground/website/public/wordpress.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description focuses on adding a custom error message, but this diff also changes the doctype line (casing/formatting). If this isn’t required for the error-message behavior, consider reverting it to keep the PR minimal and avoid unrelated churn/merge conflicts.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@mho22 mho22 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be produced by the npm run format pre-commit hook.

<head>
<title>WordPress PR Previewer</title>
<meta charset="utf-8" />
Expand Down Expand Up @@ -190,8 +190,10 @@
}
} else if (error === 'artifact_invalid') {
errorDiv.innerText = `The PR ${prNumber} requires a rebase before it can be previewed.`;
} else if (error === 'artifact_expired') {
errorDiv.innerText = `The PR ${prNumber} couldn't be previewed because the CI build artifact has expired. To load that pull request, the author or a maintainer should push a new commit, rebase, or rerun the CI job to trigger a fresh CI build.`;
} else {
errorDiv.innerText = `The PR ${prNumber} couldn't be previewed due to an unexpected error. Please try again later or fill an issue in the WordPress Playground repository.`;
errorDiv.innerText = `The PR ${prNumber} couldn't be previewed due to an unexpected error. Please try again later or file an issue in the WordPress Playground repository.`;
// https://github.com/WordPress/wordpress-playground/issues/new
}
submitting = false;
Expand Down
6 changes: 5 additions & 1 deletion packages/playground/website/src/github/preview-pr/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,13 @@ export default function PreviewPRForm({
setError(
`The PR ${ref} requires a rebase before it can be previewed.`
);
} else if (error === 'artifact_expired') {
setError(
`The PR ${ref} couldn't be previewed because the CI build artifact has expired. To load that pull request, the author or a maintainer should push a new commit, rebase, or rerun the CI job to trigger a fresh CI build.`
);
} else {
setError(
`The PR ${ref} couldn't be previewed due to an unexpected error. Please try again later or fill an issue in the WordPress Playground repository.`
`The PR ${ref} couldn't be previewed due to an unexpected error. Please try again later or file an issue in the WordPress Playground repository.`
);
// https://github.com/WordPress/wordpress-playground/issues/new
}
Expand Down
Loading