[CLI-util] Replace Xdebug console logs with CLI output#3460
Open
[CLI-util] Replace Xdebug console logs with CLI output#3460
Conversation
Collaborator
Author
|
8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Both
@php-wasm/cliand@wp-playground/cliduplicate the same inline ANSI formatting helpers and use rawconsole.logcalls for Xdebug output. This makes the output inconsistent across CLIs and harder to maintain.This pull request extracts a shared
CLIOutputbase class into@php-wasm/cli-utiland replaces all Xdebug-relatedconsole.logcalls with it in both CLIs.Implementation details
@php-wasm/cli-util: provides TTY-aware ANSI formatting and generic output methods. Uses a configurable writeStream and respects a verbosity setting.@php-wasm/cli: removed standalone formatting functions and /* eslint-disable no-console */. ImportsCLIOutputfrom@php-wasm/cli-utildirectly. All Xdebugconsole.logcalls replaced withcliOutput.print().@wp-playground/cli: the existingCLIOutputclass now extends the base from@php-wasm/cli-util, removing its duplicated private formatting methods. Playground-specific methods remain. Standalone formatting functions inrun-cli.tsremoved. All Xdebugconsole.logcalls replaced withcliOutputmethod calls.CLIOutputclass covering formatting, output methods, quiet mode suppression, and getter behavior.Testing Instructions (or ideally a Blueprint)
CLI
🧪
packages/php-wasm/cli-util/src/test/cli-output.spec.ts