Plugin Directory - translation sync: save overwritten strings as old#591
Open
timse201 wants to merge 4 commits intoWordPress:trunkfrom
Open
Plugin Directory - translation sync: save overwritten strings as old#591timse201 wants to merge 4 commits intoWordPress:trunkfrom
timse201 wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Fix invalid property translation_status. This prevents translations from being imported with null and the fallback by GlotPress to current.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
timse201
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to trac ticket: 6320
fixes: 8217
If we sync strings from dev to stable, the overwritten (fuzzy) string in stable will fire gp_translation_prepare_for_save again. Since there is no check for old strings, this one becomes current again because it adopts the status from the map. As a result, there are 2 current strings in stable.