Draft
Conversation
don't use them in the result yet.
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 97.84% 98.00% +0.15%
==========================================
Files 19 19
Lines 697 701 +4
==========================================
+ Hits 682 687 +5
+ Misses 15 14 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't use them in the result yet.
IP Secure interfaces use
BusInterfaceto transport name and leave the name attribute ofAdditionalAddresstags an empty string. I don't know howBusInterface[@AddressIndex]relates to anAdditionalAddresstag.Also there are no communication objects for AdditionalAddress so maybe they should have their own root key in the final result. A BusInterface may have
Connectorscontaining their Associations asGroupAddressRefId- which doesn't really add to our current reference schema (GroupAddress -> CommunicationObject and Device -> CommunicationObject) 😬