Conversation
There was a problem hiding this comment.
Pull request overview
This pull request extends the KNX project parsing pipeline to extract additional semantic metadata from application program XML and expose it in the parsed project output.
Changes:
- Parse
Semanticsattributes for Channels (functional blocks) and ComObjectRefs (DPAs) in the application program loader. - Propagate parsed semantics into internal models and into the final
KNXProjectoutput structure. - Update JSON stubs to include the new output fields (
dpas,functional_blocks).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| xknxproject/xml/parser.py | Adds dpas and functional_blocks to the final transformed output. |
| xknxproject/util.py | Introduces helpers to parse semantic functional blocks and DPAs from XML Semantics. |
| xknxproject/models/models.py | Adds model fields and wiring to carry semantics through merging/resolution. |
| xknxproject/models/knxproject.py | Extends output TypedDicts with dpas and functional_blocks. |
| xknxproject/loader/application_program_loader.py | Parses Semantics for channels and com object refs during XML load. |
| test/resources/stubs/*.json | Updates expected parsed-project stubs with the new fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 95.17% 96.51% +1.34%
==========================================
Files 22 22
Lines 1284 1320 +36
==========================================
+ Hits 1222 1274 +52
+ Misses 62 46 -16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parses functional blocks ("knx:fb") of device channels and DPAs ("knx:dpa") of group objects as strings.
cc @ richardpolzer