-
Notifications
You must be signed in to change notification settings - Fork 169
fix: output the actual PR comment in comment-content #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -242,9 +242,8 @@ async function run(): Promise<void> { | |
| summary.addScannedFiles(changes) | ||
| printScannedDependencies(changes) | ||
|
|
||
| // include full summary in output; Actions will truncate if oversized | ||
| // PR comment/summary handling | ||
| let rendered = core.summary.stringify() | ||
| core.setOutput('comment-content', rendered) | ||
|
|
||
| // Handle large summaries by uploading as artifact | ||
| rendered = await handleLargeSummary(rendered) | ||
|
|
@@ -257,6 +256,9 @@ async function run(): Promise<void> { | |
| rendered = minSummary | ||
| } | ||
|
|
||
| // Set the actual PR comment as output (minimal version if too large for a comment on GitHub) | ||
| core.setOutput('comment-content', rendered) | ||
|
|
||
|
Comment on lines
+259
to
+261
|
||
| // update the PR comment if needed with the right-sized summary | ||
| await commentPr(rendered, config, issueFound) | ||
| } catch (error) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment "include full summary in output" is now misleading:
comment-contentis no longer set to the fullcore.summary.stringify()result, but to the post-processedrenderedvalue afterhandleLargeSummaryand the MAX_COMMENT_LENGTH fallback. Please update or remove this comment to match the new behavior.