fix: Flicker when scrolling virtualizer in and out of view#9902
Merged
devongovett merged 1 commit intomainfrom Apr 10, 2026
Merged
fix: Flicker when scrolling virtualizer in and out of view#9902devongovett merged 1 commit intomainfrom
devongovett merged 1 commit intomainfrom
Conversation
|
Build successful! 🎉 |
reidbarber
approved these changes
Apr 9, 2026
snowystinger
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed on staging docs that if you scroll past the List layout example and then back up, some of the items flicker in and out of view. This is due to a logic error in ListLayout. We adjust the visible rectangle to try to keep the number of visible rows consistent by rounding the y position and height. But when we adjust the y position, we also need to add the adjusted difference to the height to ensure the rectangle still covers the originally requested region.
Also noticed that scrollview was continuously emitting updates for virtualizer that were entirely out of view, so I've prevented that as well (should be just an optimization).
Test instructions
Open the PR build for virtualizer docs. Scroll past the list layout example and back up and down a few times and verify that there is no flickering.