Reimport: clearing objects in the initial index if the temporary index has zero objects

[borealsmith]

No description provided.

[nunomaduro]

@chloelbn will jump on this.

[nunomaduro]

@chloelbn Can you review this one?

[chloelbn]

Hello @borealsmith,

Thanks for your PR! I’ve reviewed and the code seems fine, great work! Would you mind adding some tests along your feature, to ensure everything is working as intended? You can take as an example the test for the Reimport Command (https://github.com/algolia/scout-extended/blob/master/tests/Features/ReimportCommandTest.php) and add in this file a test case with 0 object to import.

[borealsmith]

Hi @chloelbn,

Thank you very much for the review and feedback. Of course, no problem, my pleasure to add the test case you mention.

Best Regards,

[borealsmith]

Hi, @nunomaduro @chloelbn
Sorry for the late feedback. I'll try to find some time and write the test sometime next week.

[borealsmith]

Hi,
I finally managed to add the test case for ReimportCommand in case of an empty reimport.
Best Regards,

[emanueljacob]

can we merge this?