Use cimg/php native extension install script in CI#328
Open
jnoordsij wants to merge 1 commit intoalgolia:masterfrom
Open
Use cimg/php native extension install script in CI#328jnoordsij wants to merge 1 commit intoalgolia:masterfrom
jnoordsij wants to merge 1 commit intoalgolia:masterfrom
Conversation
jnoordsij
force-pushed
the
ci-update-php-extension-installs
branch
from
af9a120 to
bea4def
Compare
jnoordsij
force-pushed
the
ci-update-php-extension-installs
branch
from
bea4def to
e1bdb97
Compare
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Alter PHP extension installation in CI to use officially supported method.
See also https://github.com/CircleCI-Public/cimg-php/blob/main/README.md#php-extensions.
What problem is this fixing?
In the current CI test job, PHP extensions are installed through the
ppa:ondrej/phprepository. Although a very useful repository, it is not suitable for this purpose, as the installed extensions are possibly incompatible with the installed PHP version due to using different source code versions.My assumption is that this currently goes undetected as the call currently causes an entire second PHP version to be installed, see e.g. https://app.circleci.com/pipelines/github/algolia/scout-extended/255/workflows/ec6dc973-ce16-4d43-82e8-a61c2b2b4cd4/jobs/2079/parallel-runs/0/steps/0-104.
Note: alternatively, the entire call could be removed, since both extensions are part of the base
cimg/phpimage already. However, this may cause breakage in the future if the list of default extensions of this image is altered.