Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sounddeviceimport tomic_stream()main()-scoped microphone import dependencywhisper-baseauto-downloadable and stop advertising unsupportedwhisper-tinyWhy
mic_stream()usessd.InputStream,sd.sleep, andsd.PortAudioError, butsounddevice as sdwas only imported later insidemain(). That can break the microphone path before the symbol is in scope.The same demo also advertised
whisper-baseas the default andwhisper-tinyas a valid choice while the auto-download helper only knew aboutsmall,medium, andlarge-v3-turbo. That made the documented/default setup path inconsistent before inference even started.Closes #349.
Validation
python -m py_compile Demos/ASR/Whisper/run_whisper.pymic_stream()smoke with a fakesounddevicemodule, no real microphone access, and no NPU/model load