-
Notifications
You must be signed in to change notification settings - Fork 151
fix: increase JSONL stream scanner buffer to prevent silent truncation #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gn00295120
wants to merge
2
commits into
anthropics:main
Choose a base branch
from
gn00295120:fix/jsonl-scanner-buffer-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+107
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package jsonl_test | ||
|
|
||
| import ( | ||
| "bufio" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/anthropics/anthropic-sdk-go/packages/jsonl" | ||
| ) | ||
|
|
||
| type testItem struct { | ||
| ID int `json:"id"` | ||
| Data string `json:"data"` | ||
| } | ||
|
|
||
| func TestStream_SmallLines(t *testing.T) { | ||
| body := `{"id":1,"data":"hello"}` + "\n" + `{"id":2,"data":"world"}` + "\n" | ||
| res := &http.Response{ | ||
| Body: io.NopCloser(strings.NewReader(body)), | ||
| } | ||
|
|
||
| stream := jsonl.NewStream[testItem](res, nil) | ||
| defer stream.Close() | ||
|
|
||
| count := 0 | ||
| for stream.Next() { | ||
| count++ | ||
| item := stream.Current() | ||
| if item.ID != count { | ||
| t.Errorf("expected id %d, got %d", count, item.ID) | ||
| } | ||
| } | ||
| if err := stream.Err(); err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| if count != 2 { | ||
| t.Fatalf("expected 2 items, got %d", count) | ||
| } | ||
| } | ||
|
|
||
| func TestStream_LargeLineExceeding64KB(t *testing.T) { | ||
| // Create a JSON line that exceeds the default bufio.Scanner limit (64 KB). | ||
| // Before the fix, this caused the scanner to silently stop with | ||
| // "bufio.Scanner: token too long", making the stream appear empty. | ||
| largeData := strings.Repeat("x", bufio.MaxScanTokenSize+1024) // ~65 KB + 1 KB | ||
| line := fmt.Sprintf(`{"id":1,"data":"%s"}`, largeData) | ||
| body := line + "\n" | ||
|
|
||
| res := &http.Response{ | ||
| Body: io.NopCloser(strings.NewReader(body)), | ||
| } | ||
|
|
||
| stream := jsonl.NewStream[testItem](res, nil) | ||
| defer stream.Close() | ||
|
|
||
| if !stream.Next() { | ||
| t.Fatalf("expected stream.Next() to return true for large line, got false; err: %v", stream.Err()) | ||
| } | ||
| item := stream.Current() | ||
| if item.ID != 1 { | ||
| t.Fatalf("expected id 1, got %d", item.ID) | ||
| } | ||
| if len(item.Data) != len(largeData) { | ||
| t.Fatalf("expected data length %d, got %d", len(largeData), len(item.Data)) | ||
| } | ||
| if err := stream.Err(); err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestStream_NilResponse(t *testing.T) { | ||
| stream := jsonl.NewStream[testItem](nil, nil) | ||
| defer stream.Close() | ||
| if stream.Next() { | ||
| t.Fatal("expected Next() to return false for nil response") | ||
| } | ||
| if err := stream.Err(); err == nil { | ||
| t.Fatal("expected error for nil response") | ||
| } | ||
| } | ||
gn00295120 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| func TestStream_Error(t *testing.T) { | ||
| stream := jsonl.NewStream[testItem](nil, fmt.Errorf("request failed")) | ||
| defer stream.Close() | ||
| if stream.Next() { | ||
| t.Fatal("expected Next() to return false when error is set") | ||
| } | ||
| if err := stream.Err(); err == nil || err.Error() != "request failed" { | ||
| t.Fatalf("expected 'request failed' error, got: %v", err) | ||
| } | ||
| } | ||
gn00295120 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.