Add xattr-based attribute support to LocalFileSystem#630
Add xattr-based attribute support to LocalFileSystem#630Barre wants to merge 1 commit intoapache:mainfrom
Conversation
|
I think this needs fixes / code adjustments for WASM & Windows. |
9869ef3 to
6aaf5cf
Compare
My most recent changes should do the trick. |
|
Needs a rebase, otherwise looks good to me. @tustvold any objections? |
|
LGTM, just a few comments
|
6aaf5cf to
0fe78e7
Compare
Should be ok now. |
| wasm-bindgen-futures = "0.4.18" | ||
| futures-channel = {version = "0.3", features = ["sink"]} | ||
|
|
||
| [features] |
There was a problem hiding this comment.
Isn't this missing the xattr feature?
There was a problem hiding this comment.
Ah, I thought you didn't want it by default.
There was a problem hiding this comment.
Yes, but you still need to define the feature. An optional dependency doesn't automatically define a feature, no?
There was a problem hiding this comment.
$ cargo metadata --format-version 1 --no-deps | jq '.packages[0].features'
[...]
"xattr": [
"dep:xattr"
]
There was a problem hiding this comment.
Weird, but since it passes the test this is obviously working 🤷
625c402 to
1141ff0
Compare
Store object attributes as extended attributes on the local filesystem, enabling put_opts and put_multipart_opts to persist attributes. Attributes are set on the staging file before atomic rename to preserve consistency. - Add xattr dependency (gated by fs feature) - Map standard attributes to user.* xattr namespace - Read attributes back in get_opts
1141ff0 to
129d021
Compare
|
(Ran |
|
I think we need to do something about Windows. So I think selecting this feature on Windows should probably lead to Or you find a way to set file attributes on Windows (see for example this discussion), but I think this might be a bit out of scope for this PR. |
Closes #331
Store object attributes as extended attributes on the local filesystem, enabling put_opts and put_multipart_opts to persist attributes. Attributes are set on the staging file before atomic rename to preserve consistency.
Rationale for this change
The LocalFileSystem currently does not support attributes.
What changes are included in this PR?
The LocalFileSystem now supports attributes.
Are there any user-facing changes?
The LocalFileSystem now supports attributes.