fix(retry): respect range header on retry#690
Open
dentiny wants to merge 1 commit intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #654
Rationale for this change
Disclaimer: this PR tries to solve the same problem as #609, but did a different way: I tried to keep the bytes since I observe (for my usage personally) most of returned range is a superset for requested range.
Feel free to close it if maintainers think it's a duplicate.
Currently retry stream returns returned body directly without checking the range header.
arrow-rs-object-store/src/client/get.rs
Line 247 in e89f62b
What changes are included in this PR?
Since retried response could contain ranges which don't match with requested one, so I tried to keep useful parts if applicable.
Are there any user-facing changes?
No.