GH-15047: [Python]: switch from pytz to zoneinfo by default for string to tzinfo conversion#49694
Draft
jorisvandenbossche wants to merge 4 commits intoapache:mainfrom
Draft
GH-15047: [Python]: switch from pytz to zoneinfo by default for string to tzinfo conversion#49694jorisvandenbossche wants to merge 4 commits intoapache:mainfrom
jorisvandenbossche wants to merge 4 commits intoapache:mainfrom
Conversation
… string to tzinfo conversion
|
|
Member
Author
|
@github-actions crossbow submit test-pandas |
|
Revision: dc184fe Submitted crossbow builds: ursacomputing/crossbow @ actions-cdf269df89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
zoneinfois available starting with Python 3.9, so we can now assume that it is available, and so we can switch from by default returningpytztimezones to returnzoneinfotimezones (ordatetime.timezonefor fixed offsets).Only keeping pytz as fallback for strings that are not supported by
zoneinfobut were supported bypytz. Later, we should maybe deprecate that fallback.What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs.
It is a different object that we return (different class), which a different API, so for people relying on that, this is a breaking change.