Revert "Fix NameError when pydot is not installed in Beam Playground"#38134
Revert "Fix NameError when pydot is not installed in Beam Playground"#38134
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change that introduced an explicit check for the pydot library. The change was identified as causing regressions in Python unit test workflows, and the intended long-term solution is to ensure pydot is properly installed in the environment instead of handling its absence at runtime. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
R: @aIbrahiim cc: @liferoad |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38134 +/- ##
============================================
- Coverage 56.89% 56.81% -0.09%
Complexity 3428 3428
============================================
Files 1178 1182 +4
Lines 187520 188470 +950
Branches 3593 3593
============================================
+ Hits 106692 107076 +384
- Misses 77434 78000 +566
Partials 3394 3394
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reverts #38074
breaks python unit test workflows
We should install pydot in Beam Playground as a fix to #37829