Skip to content

Revert "Fix NameError when pydot is not installed in Beam Playground"#38134

Merged
Abacn merged 1 commit intomasterfrom
revert-38074-fix/pydot-nameerror-playground
Apr 9, 2026
Merged

Revert "Fix NameError when pydot is not installed in Beam Playground"#38134
Abacn merged 1 commit intomasterfrom
revert-38074-fix/pydot-nameerror-playground

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Apr 9, 2026

Reverts #38074

breaks python unit test workflows

We should install pydot in Beam Playground as a fix to #37829

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that introduced an explicit check for the pydot library. The change was identified as causing regressions in Python unit test workflows, and the intended long-term solution is to ensure pydot is properly installed in the environment instead of handling its absence at runtime.

Highlights

  • Reversion of error handling: Removed the explicit NameError check for pydot installation within the pipeline graph construction logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Apr 9, 2026

R: @aIbrahiim

cc: @liferoad

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.81%. Comparing base (a1f260b) to head (c13f81e).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38134      +/-   ##
============================================
- Coverage     56.89%   56.81%   -0.09%     
  Complexity     3428     3428              
============================================
  Files          1178     1182       +4     
  Lines        187520   188470     +950     
  Branches       3593     3593              
============================================
+ Hits         106692   107076     +384     
- Misses        77434    78000     +566     
  Partials       3394     3394              
Flag Coverage Δ
python 79.61% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Apr 9, 2026

R: @claudevdm @ahmedabu98

@Abacn Abacn merged commit b296b40 into master Apr 9, 2026
114 of 115 checks passed
@Abacn Abacn deleted the revert-38074-fix/pydot-nameerror-playground branch April 9, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants