Skip to content

feat(build): add progress output to config_brpc.sh#3262

Merged
chenBright merged 1 commit intoapache:masterfrom
darion-yaphet:fix/config-brpc-verbose-output
Apr 8, 2026
Merged

feat(build): add progress output to config_brpc.sh#3262
chenBright merged 1 commit intoapache:masterfrom
darion-yaphet:fix/config-brpc-verbose-output

Conversation

@darion-yaphet
Copy link
Copy Markdown
Contributor

The configuration script previously ran silently with no visible output, making it hard to tell whether it was working or what it detected. Add colored progress messages for each stage: system info, dependency discovery, output file generation, and a final configuration summary.

What problem does this PR solve?

Issue Number: resolve

Problem Summary: Running config_brpc.sh produces no visible output during configuration, leaving users unable to tell if the script is working, what dependencies were detected, or whether configuration succeeded.

What is changed and the side effects?

Changed:

  • Added colored progress output to config_brpc.sh covering four stages: system/compiler info, dependency discovery (openssl, gflags, protobuf, leveldb, protoc),
    output file generation, and a final configuration summary.
  • No logic changes — only printf statements were added to stdout. All existing error messages to stderr remain unchanged.

Side effects:

  • Performance effects: Negligible. Only adds a few printf calls.

  • Breaking backward compatibility: None. The script's exit codes, generated config.mk, and src/butil/config.h are identical. Scripts that parse stderr are unaffected since all new output goes to stdout.

  • Breaking backward compatibility:


Check List:

The configuration script previously ran silently with no visible output,
making it hard to tell whether it was working or what it detected.
Add colored progress messages for each stage: system info, dependency
discovery, output file generation, and a final configuration summary.
Copy link
Copy Markdown
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenBright chenBright merged commit d269b69 into apache:master Apr 8, 2026
17 checks passed
@darion-yaphet darion-yaphet deleted the fix/config-brpc-verbose-output branch April 8, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants