MySQL: Support SHOW FULL PROCESSLIST syntax#2292
Merged
yoavcloud merged 1 commit intoapache:mainfrom Apr 10, 2026
Merged
Conversation
yoavcloud
reviewed
Apr 9, 2026
src/parser/mod.rs
Outdated
| } else if self.parse_keyword(Keyword::FUNCTIONS) { | ||
| Ok(self.parse_show_functions()?) | ||
| } else if self.parse_keyword(Keyword::PROCESSLIST) | ||
| && dialect_of!(self is MySqlDialect | GenericDialect) |
Contributor
There was a problem hiding this comment.
Is this gate necessary? We are OK with the parser being permissive and having all dialects accept this statement.
Contributor
Author
There was a problem hiding this comment.
I wasn't sure if we were fine with it being permissive so I added the gate matching some other branches here just in case. I made the changes to remove the dialect gate.
yoavcloud
requested changes
Apr 9, 2026
f3c332f to
5a38c63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, parsing the syntax
SHOW FULL PROCESSLISTwith the MySQL dialect results in an error even though it's valid as seen in the documentation. This PR adds support for this syntax to the parser.This is my first time contributing here, so please let me know if anything needs to be changed.
https://dev.mysql.com/doc/refman/8.4/en/show-processlist.html