Skip to content

[VL] Fix compression libs linking for arrow #11879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
infvg wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −7
Open

[VL] Fix compression libs linking for arrow #11879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions cpp/core/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,28 @@ if(DEFINED ENV{HADOOP_HOME})
else()
set(LIBHDFS3_DESTINATION ${CMAKE_INSTALL_LIBDIR})
endif()
find_package(ZLIB REQUIRED)

target_link_libraries(gluten PUBLIC Arrow::arrow
Arrow::arrow_bundled_dependencies)
find_library(LZ4_LIBRARY NAMES lz4 liblz4)
find_library(ZSTD_LIBRARY NAMES zstd libzstd)
find_library(SNAPPY_LIBRARY NAMES snappy libsnappy)

set(ARROW_EXTRA_DEPS "")
if(LZ4_LIBRARY)
list(APPEND ARROW_EXTRA_DEPS ${LZ4_LIBRARY})
endif()
if(ZSTD_LIBRARY)
list(APPEND ARROW_EXTRA_DEPS ${ZSTD_LIBRARY})
endif()
if(SNAPPY_LIBRARY)
list(APPEND ARROW_EXTRA_DEPS ${SNAPPY_LIBRARY})
endif()
list(APPEND ARROW_EXTRA_DEPS ZLIB::ZLIB)

target_link_libraries(
gluten
PUBLIC Arrow::arrow Arrow::arrow_bundled_dependencies
PRIVATE ${ARROW_EXTRA_DEPS})
target_link_libraries(gluten PRIVATE google::glog)

install(TARGETS gluten DESTINATION ${CMAKE_INSTALL_LIBDIR})
Expand All @@ -241,8 +260,16 @@ add_custom_command(
POST_BUILD
COMMAND ld $<TARGET_FILE:gluten> || true
COMMENT "Checking ld result of libgluten.so")
add_custom_command(
TARGET gluten
POST_BUILD
COMMAND ldd $<TARGET_FILE:gluten> || true
COMMENT "Checking ldd result of libgluten.so")
if(APPLE)
add_custom_command(
TARGET gluten
POST_BUILD
COMMAND otool -L $<TARGET_FILE:gluten> || true
COMMENT "Checking shared library dependencies of gluten")
elseif(UNIX)
add_custom_command(
TARGET gluten
POST_BUILD
COMMAND ldd $<TARGET_FILE:gluten> || true
COMMENT "Checking shared library dependencies of gluten")
endif()
Loading