[GLUTEN-11888] [VL] Parallel build hash table to improve bhj performance#11889
Merged
JkSelf merged 4 commits intoapache:mainfrom Apr 9, 2026
Merged
[GLUTEN-11888] [VL] Parallel build hash table to improve bhj performance#11889JkSelf merged 4 commits intoapache:mainfrom
JkSelf merged 4 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
Contributor
jinchengchenghh
left a comment
jinchengchenghh
left a comment
There was a problem hiding this comment.
Overall looks good, only a small nits, could you also describe the performance and the limitation in PR description?
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala
Show resolved
Hide resolved
Contributor
Author
|
@jinchengchenghh Already updated the performance data in PR description. Please help to review again. Thanks. |
jinchengchenghh
approved these changes
Apr 8, 2026
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
malinjawi
pushed a commit
to malinjawi/incubator-gluten
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
spark.gluten.velox.broadcast.build.targetBytesPerThreaconfiguration to dynamically calculate hash table thread counts based on raw data size.The existing implementation uses a single thread to build the hash table. When the hash table threshold is set to a large value (e.g., 800MB), the build time becomes a bottleneck. Our benchmarks on TPC-DS Q69 (10TB) show that building an 800MB hash table with a single thread takes 37s. By enabling parallel builds with this PR, the execution time drops to 25s.
How was this patch tested?
Existing tests
Was this patch authored or co-authored using generative AI tooling?
No
Related issue: #11888