Skip to content

Fix: issue #1297: datasaver does not work with __future__.annotations #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kreczko wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: issue #1297: datasaver does not work with __future__.annotations #1298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
422b9a7
fix(issue #1297): add annotations to tests and add str check to valid…
kreczko Mar 28, 2025
e4f07b9
refactor(datasaver.validate): use typing.get_type_hints instead of in…
kreczko Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hamilton/function_modifiers/adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ def validate(self, fn: Callable):
f"Function: {fn.__qualname__} must have a return annotation."
)
# check that the return type is a dict
if return_annotation not in (dict, Dict):
if return_annotation not in (dict, Dict, "dict", "dict_"):
raise InvalidDecoratorException(f"Function: {fn.__qualname__} must return a dict.")

def generate_nodes(self, fn: Callable, config) -> List[node.Node]:
Expand Down
2 changes: 2 additions & 0 deletions tests/function_modifiers/test_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import dataclasses
from collections import Counter
from typing import Any, Collection, Dict, List, Tuple, Type
Expand Down