Core: Make util test classes and methods package-private#15919
Open
ZephyrYWZhou wants to merge 1 commit intoapache:mainfrom
Open
Core: Make util test classes and methods package-private#15919ZephyrYWZhou wants to merge 1 commit intoapache:mainfrom
ZephyrYWZhou wants to merge 1 commit intoapache:mainfrom
Conversation
JUnit 5 does not require test classes or methods to be public. Update test classes in core util package to use package-private visibility, consistent with project conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update test classes and methods under
core/src/test/.../util/to use package-private visibility by removing unnecessarypublicmodifiers.Why
JUnit 5 does not require test classes or methods to be public, and the project convention recommends package-private visibility unless broader access is required. These 25 test files in the core util package still used
publicvisibility and were updated to align with the convention.Notes
FakeTickerremains public because it is referenced by test classes in other packages (hadoop,rest).TestLockManagers) remain public as required by the interface contract.