API: Fix FileRange validation order#15929
Open
aviralgarg05 wants to merge 1 commit intoapache:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15922
Summary
Fix
FileRangeconstructor validation so negativeoffsetandlengthvalues are rejected before the fields are assigned.Previously, the constructor validated
length()andoffset()before assigning the constructor arguments to the fields. That meant the checks were reading the default field values instead of the incoming arguments, allowing malformed ranges with negative values to be created.Changes
FileRangelengthoffsetWhy this matters
Invalid
FileRangeinstances can propagate into vectored reads and fail later at runtime. Rejecting bad inputs at construction time keeps the API behavior correct and surfaces the error at the actual boundary where the bad state is introduced.Testing
./gradlew :iceberg-api:test./gradlew :iceberg-api:spotlessCheck