IGNITE-28404 Fixed the stopping of lease prolongation during lease negotiation#7931
Open
denis-chudov wants to merge 3 commits intoapache:mainfrom
Open
IGNITE-28404 Fixed the stopping of lease prolongation during lease negotiation#7931denis-chudov wants to merge 3 commits intoapache:mainfrom
denis-chudov wants to merge 3 commits intoapache:mainfrom
Conversation
denis-chudov
changed the title
alievmirza
reviewed
Apr 10, 2026
| .deniedLeaseExpirationTimeLong(time) | ||
| .build(); | ||
|
|
||
| clusterService.messagingService().respond(sender, response, correlationId); |
Contributor
There was a problem hiding this comment.
what if correlationId is null?
| integrationTestImplementation project(':ignite-table') | ||
| integrationTestImplementation project(':ignite-transactions') | ||
| integrationTestImplementation project(':ignite-eventlog') | ||
| integrationTestImplementation project(':ignite-placement-driver-api') |
Contributor
There was a problem hiding this comment.
do we really need this?
| } else { | ||
| long time = lease.getLeaseholderId() == null | ||
| ? clockService.current().longValue() | ||
| : NULL_HYBRID_TIMESTAMP; |
Contributor
There was a problem hiding this comment.
could you please explain why we return NULL_HYBRID_TIMESTAMP? Why not lease.getExpirationTime().longValue()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28404