KAFKA-20417: Add KIP-1035 self-managed offset recovery integration tests#21998
Open
bbejeck wants to merge 3 commits intoapache:trunkfrom
Open
KAFKA-20417: Add KIP-1035 self-managed offset recovery integration tests#21998bbejeck wants to merge 3 commits intoapache:trunkfrom
bbejeck wants to merge 3 commits intoapache:trunkfrom
Conversation
mjsax
reviewed
Apr 8, 2026
| kafkaStreams.close(STREAMS_CLOSE_TIMEOUT); | ||
| } | ||
|
|
||
| private KafkaStreams startStreams() throws Exception { |
Member
There was a problem hiding this comment.
Should we reuse IntegrationTestUtils#startApplicationAndWaitUntilRunning instead of adding these helpers?
Member
Author
There was a problem hiding this comment.
I've left startStreams since it handles a couple of operations cleaning up the test some, but it does reuse IntegrationTestUtils.startApplicationAndWaitUntilRunning
...test/java/org/apache/kafka/streams/integration/SelfManagedOffsetRecoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/kafka/streams/integration/SelfManagedOffsetRecoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/kafka/streams/integration/SelfManagedOffsetRecoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/kafka/streams/integration/SelfManagedOffsetRecoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/kafka/streams/integration/SelfManagedOffsetRecoveryIntegrationTest.java
Outdated
Show resolved
Hide resolved
| // Phase 2: shut down instance 1, wipe its entire state, then restart. | ||
| // This simulates the LittleHorse scenario: complete state deletion followed by | ||
| // changelog restoration. The standby tasks on this instance will have stores | ||
| // that were never initialized with offsets. |
Member
There was a problem hiding this comment.
The standby tasks on this instance will have stores that were never initialized with offsets.
How do we know that there will be standby task on streams1 ?
Member
Author
There was a problem hiding this comment.
I've added assertions to explicity show the standbys assigned to streams1
Member
Author
|
@mjsax addressed comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SelfManagedOffsetRecoveryIntegrationTestandRocksDBStoreTestingUtilsTests verify Kafka Streams recovers correctly after unclean shutdowns
when offsets are stored in RocksDB column families (KIP-1035). Covers:
offsets triggering task corruption detection
wipe)
Reviewers: Matthias J. Sax matthias@confluent.io