Open
Conversation
mirkoCrobu
force-pushed
the
custom-model-validation
branch
from
483b715 to
c94b1d8
Compare
dido18
reviewed
Apr 1, 2026
internal/orchestrator/modelsindex/custommodel/custommodel_test.go
Outdated
Show resolved
Hide resolved
internal/orchestrator/modelsindex/custommodel/custommodel_test.go
Outdated
Show resolved
Hide resolved
internal/orchestrator/modelsindex/custommodel/custommodel_test.go
Outdated
Show resolved
Hide resolved
internal/orchestrator/modelsindex/custommodel/testdata/my-model/model.yaml
Outdated
Show resolved
Hide resolved
mirkoCrobu
force-pushed
the
custom-model-validation
branch
from
724db65 to
e0d07d6
Compare
dido18
reviewed
Apr 3, 2026
Comment on lines
+97
to
+102
| requiredFields := []string{ | ||
| "ei-project-id", | ||
| "ei-impulse-id", | ||
| "ei-impulse-name", | ||
| "ei-deployment-version", | ||
| } |
Contributor
There was a problem hiding this comment.
I would double-check that all these tags are mandatory for the edge impulse.
Maybe only the project ID and impulse ID are mandatory?
Contributor
Author
There was a problem hiding this comment.
From our side, we don't use these fields. We just store them and return to the front-end. We could check into the Figma flows how they use the information, but I guess it is better to check directly with the front-end.
Contributor
Author
There was a problem hiding this comment.
for example I see from App-lab that they read ei-deployment-version to check if an installed model is outdated:
Contributor
Author
There was a problem hiding this comment.
I confirm that they are all mandatory for App Lab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Change description
Additional Notes
Reviewer checklist
main.