Open
Conversation
mirkoCrobu
reviewed
Apr 8, 2026
Comment on lines
+57
to
59
| res := BrickListResult{Bricks: make([]BrickListItem, len(s.bricksIndex.ListBricks(nil)))} | ||
| for i, brick := range s.bricksIndex.ListBricks(filter) { | ||
| res.Bricks[i] = BrickListItem{ |
Contributor
There was a problem hiding this comment.
I am not sure, but I guess s.bricksIndex.ListBricks(...) should have the same param?
Suggested change
| res := BrickListResult{Bricks: make([]BrickListItem, len(s.bricksIndex.ListBricks(nil)))} | |
| for i, brick := range s.bricksIndex.ListBricks(filter) { | |
| res.Bricks[i] = BrickListItem{ | |
| bricks := s.bricksIndex.ListBricks(filter) | |
| res := BrickListResult{Bricks: make([]BrickListItem, len(bricks))} | |
| for i, brick := range bricks { |
| // act | ||
| got := b.ListBricks(tt.filter) | ||
| require.Equal(t, len(tt.wantBricks), len(got)) | ||
| require.Equal(t, tt.wantBricks[0].ID, got[0].ID) |
Contributor
There was a problem hiding this comment.
what about the this?
Suggested change
| require.Equal(t, tt.wantBricks[0].ID, got[0].ID) | |
| require.Equal(t, tt.wantBricks, got) |
Comment on lines
+802
to
+808
| parameters: | ||
| - description: If true, only returns bricks supported by the current board. | ||
| in: query | ||
| name: supported_only | ||
| schema: | ||
| description: If true, only returns bricks supported by the current board. | ||
| type: boolean |
Contributor
There was a problem hiding this comment.
duplicated generation of the description.. something wrong with the docs.go??
Contributor
|
This is superseded by #343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a filter to filter out bricks.
Add the list of the supported bricks to a brick.
Create a filter to filter out unsupported bricks.
Change description
Additional Notes
Reviewer checklist
main.