Open
Conversation
dido18
requested changes
Apr 8, 2026
|
|
||
| // LocalBrickRename renames a local brick by changing its ID, folder name, and display name. | ||
| // The newID is derived from the newName by the caller (handler layer). | ||
| func (s *Service) LocalBrickRename(appCurrent *app.ArduinoApp, oldID, newID, newName string) (_ LocalBrickRenameResult, _err error) { |
Contributor
There was a problem hiding this comment.
I would add unit tests for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds LocalBrickRename action.
Change description
Updates local Bricks Name (and consequently ID).
In case of errors, it tries to keep the system in a consistent state using deferred rollbacks.
Additional Notes
Reviewer checklist
main.