Standard JSON input / output types#16587
Draft
erak wants to merge 2 commits intostate-mutability-from-stringfrom
Draft
Standard JSON input / output types#16587erak wants to merge 2 commits intostate-mutability-from-stringfrom
erak wants to merge 2 commits intostate-mutability-from-stringfrom
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #16394. Depends on #16586.
Description
In order to modularize the test execution framework, it was decided to settle on JSON as the common input / output data type for compilers under test. Since not only the testing framework, but also the CLI, which is planned to interface with the
StandardCompilerin the future, would benefit from this common types. Furthermore, these common data types could be used where (de)serialization is currently duplicated (see e.g.StandardCompilerinput parsing).Design goals
nlohmann's conventions (via ADL forto_json/from_json)Open questions
Should
StandardJSONOutputlive insidetestnamespace for now, since the test execution framework is the only place where we need the outout right now?TODO
Input
Output
Cached<T>forContractmembers that should lazy-load