SSA: Handle non-admissible stack shuffler results#16590
Open
LeviofCrypto wants to merge 2 commits intoargotorg:developfrom
Open
SSA: Handle non-admissible stack shuffler results#16590LeviofCrypto wants to merge 2 commits intoargotorg:developfrom
LeviofCrypto wants to merge 2 commits intoargotorg:developfrom
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the SSA stack shuffler call sites to stop asserting that every shuffle is admissible. Instead, the code routes non-admissible results through
requireAdmissibleShuffle(), which turnsStackTooDeepintoStackTooDeepErrorand unexpected statuses intoInternalCompilerErrorwith context about the source and target stacks.The helper is used in SSA code generation, stack layout generation, and target-size evaluation so failures are surfaced consistently from the actual consumer sites. The change also adds unit coverage for the new error mapping and wires the test into
soltest.