gateway-dk-ask: pin ASK with libxml2 2.12+ compat fix for fmc#9677
gateway-dk-ask: pin ASK with libxml2 2.12+ compat fix for fmc#9677tomazzaman wants to merge 2 commits intoarmbian:mainfrom
Conversation
Update ASK to a commit that adds a libxml2 compatibility patch for fmc. Newer libxml2 (2.12+) changed the xmlStructuredErrorFunc callback signature to take a const error pointer. Without the patch, fmc fails to compile against libxml2 2.12+ headers (Ubuntu Resolute and other distros with newer libxml2).
📝 WalkthroughWalkthroughUpdated a pinned ASK source commit in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
glibc 2.42+ (Ubuntu Resolute and later) ships const-aware strstr/strchr declarations in <string.h>. Assigning their results to non-const char* triggers -Werror=discarded-qualifiers in tools/bpf/resolve_btfids, which is compiled by the linux-headers .deb postinst on the build host. Fix by declaring the receiving variables as const char* in two places in tools/lib/bpf/libbpf.c. Matches the upstream 6.13+ fix, backported to the NXP lf-6.12.y SDK kernel (which NXP has moved off for 6.18+).
|
Went ahead and fixed the headers issue as well, however, identified another bug, so I'm fixing the whole ASK patching process for future-proofness. Will push soon. |
Description
Update the ASK repo pin to a commit that adds a libxml2 compatibility patch for
fmc.Newer libxml2 (2.12.0+, released Oct 2023) changed the
xmlStructuredErrorFunccallback signature to take aconst xmlError *instead ofxmlError *. Without the patch, fmc fails to compile against libxml2 2.12+ headers, breaking builds against newer distributions.The patch in the ASK repo uses a
LIBXML_VERSIONpreprocessor check to select the correct callback signature for both old and new libxml2.Distribution coverage
How Has This Been Tested?
Checklist:
Summary by CodeRabbit