audit: skip status:unsupported DEs + relocate audit scripts#826
audit: skip status:unsupported DEs + relocate audit scripts#826igorpecovnik merged 1 commit intomainfrom
Conversation
Two changes to the desktop matrix audit, kept in one commit
because the script move and the new behaviour land together.
1) Skip status:unsupported DEs by default
-----------------------------------------
The weekly audit was running against every YAML in
tools/modules/desktops/yaml/, including the four flagged
'status: unsupported': bianbu, budgie, deepin, kde-neon.
These are typically vendor- or release-specific desktops:
- bianbu : SpacemiT riscv64, Bianbu archive, riscv64 only
- kde-neon : Ubuntu noble/plucky only, custom KDE Neon repo
- budgie : community-maintained, mostly Ubuntu LTS
- deepin : community-maintained, sporadic distro coverage
Auditing them generates noise that isn't actionable: 'package
not in the upstream archive' is the expected state for many
of their (release, arch) combinations because the YAML doesn't
intend to ship those combinations to begin with. The Claude
apply step would then propose tier_overrides for combos that
nobody actually intends to install.
Filter them at the YAML enumeration step: read each file's
'status:' field, skip 'unsupported' by default. The list of
skipped DEs is added to the JSON report and surfaced in the
workflow's job summary so reviewers can see at a glance which
DEs were excluded.
Add a --include-unsupported CLI flag for the rare case where
someone wants to audit them anyway (e.g. before promoting one
to status: supported).
Verified locally:
- default run: audits 8 (cinnamon, enlightenment, gnome,
i3-wm, kde-plasma, mate, xfce, xmonad), skips 4
- --include-unsupported: audits all 12 as before
2) Relocate the audit scripts
-----------------------------
Move the two scripts from tools/desktops/ to
tools/modules/desktops/github/ so all desktop-related code
lives under tools/modules/desktops/. The 'github/' subdir
makes the intent clear (these are CI helpers, not runtime
modules) and parallels the .github/workflows/ layout.
tools/desktops/audit.py -> tools/modules/desktops/github/audit.py
tools/desktops/audit_apply.py -> tools/modules/desktops/github/audit_apply.py
The workflow's two python3 invocations and the audit_apply.py
prompt template are updated to point at the new paths. The
scripts themselves are unchanged on the move (only the path
strings update).
Verified the workflow still validates as YAML and the script
still runs end-to-end from the new location.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 59 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Two related changes to the desktop matrix audit, kept in one commit because the script move and the new behaviour land together.
1. Skip `status: unsupported` DEs by default
The weekly audit (#824) was running against every YAML in `tools/modules/desktops/yaml/` — including the four flagged `status: unsupported`:
Auditing them generates noise that isn't actionable: 'package not in the upstream archive' is the expected state for many of their (release, arch) combinations because the YAML doesn't intend to ship those combinations to begin with. The Claude apply step would then propose `tier_overrides` for combos nobody actually intends to install.
Filter them at the YAML enumeration step: read each file's `status:` field, skip `unsupported` by default. The list of skipped DEs is added to the JSON report and surfaced in the workflow's job summary so reviewers can see at a glance which DEs were excluded.
A new `--include-unsupported` CLI flag re-enables them for the rare case where someone wants to audit one before promoting it to `status: supported`.
Verified locally:
2. Relocate the audit scripts
Move the two scripts from `tools/desktops/` to `tools/modules/desktops/github/` so all desktop-related code lives under `tools/modules/desktops/`. The `github/` subdir makes the intent clear (these are CI helpers, not runtime modules) and parallels the `.github/workflows/` layout.
```
tools/desktops/audit.py -> tools/modules/desktops/github/audit.py
tools/desktops/audit_apply.py -> tools/modules/desktops/github/audit_apply.py
```
The workflow's two python3 invocations and the `audit_apply.py` prompt template are updated to point at the new paths. The scripts themselves are unchanged on the move (only the path strings update). The empty `tools/desktops/` directory is removed.
Test plan