Skip to content

UPSTREAM PR #2030: docs: clarify rehash guarantees for reserve() in Swiss Tables #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loci-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

UPSTREAM PR #2030: docs: clarify rehash guarantees for reserve() in Swiss Tables #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions absl/container/flat_hash_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,8 +472,13 @@ class ABSL_ATTRIBUTE_OWNER flat_hash_map
// Sets the number of slots in the `flat_hash_map` to the number needed to
// accommodate at least `count` total elements without exceeding the current
// maximum load factor, and may rehash the container if needed. After this
// returns, it is guaranteed that `count - size()` elements can be inserted
// into the `flat_hash_map` without another rehash.
// returns, it is guaranteed that `count - size()` consecutive elements can
// be inserted into the `flat_hash_map` without another rehash.
//
// NOTE: This guarantee only applies to consecutive insertions. Because of
// probing requirements, erased slots may still occupy capacity from the
// perspective of needing a rehash. Therefore, interleaving insertions and
// erasures may trigger a compacting rehash.
using Base::reserve;

// flat_hash_map::at()
Expand Down
9 changes: 7 additions & 2 deletions absl/container/flat_hash_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,13 @@ class ABSL_ATTRIBUTE_OWNER flat_hash_set
// Sets the number of slots in the `flat_hash_set` to the number needed to
// accommodate at least `count` total elements without exceeding the current
// maximum load factor, and may rehash the container if needed. After this
// returns, it is guaranteed that `count - size()` elements can be inserted
// into the `flat_hash_set` without another rehash.
// returns, it is guaranteed that `count - size()` consecutive elements can
// be inserted into the `flat_hash_set` without another rehash.
//
// NOTE: This guarantee only applies to consecutive insertions. Because of
// probing requirements, erased slots may still occupy capacity from the
// perspective of needing a rehash. Therefore, interleaving insertions and
// erasures may trigger a compacting rehash.
using Base::reserve;

// flat_hash_set::contains()
Expand Down
Loading