Skip to content

Do not dup class and module name constants #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matas-zanevicius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not dup class and module name constants #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/attr_extras/attr_initialize.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@ def apply
validate_args.call(values, klass_params)

klass_params.default_values.each do |name, default_value|
instance_variable_set("@#{name}", default_value.dup)
if (default_value.is_a?(Module) || default_value.is_a?(Class)) &&
!default_value.name.nil? &&
Module.const_defined?(
(default_value.to_s if default_value.respond_to?(:to_s)),
)
instance_variable_set("@#{name}", default_value)
else
instance_variable_set("@#{name}", default_value.dup)
end
end

klass_params.positional_args.zip(values).each do |name, value|
Expand Down
12 changes: 12 additions & 0 deletions spec/attr_extras/attr_initialize_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ def self.name
_(example.instance_variable_get("@baz")).must_equal "Baz"
end

it "can set constants as default values for positional arguments" do
klass = Class.new do
attr_initialize [ foo: AttrExtras ]
end

example = klass.new
_(example.instance_variable_get("@foo")).must_equal AttrExtras

example = klass.new(foo: AttrExtras::AttrInitialize)
_(example.instance_variable_get("@foo")).must_equal AttrExtras::AttrInitialize
end

it "treats hash values as optional" do
klass = Class.new do
attr_initialize :foo, [ :bar, :baz ]
Expand Down