Added SU paths for root validation checks.#21
Open
teja8352 wants to merge 1 commit intocapacitor-community:masterfrom
Open
Added SU paths for root validation checks.#21teja8352 wants to merge 1 commit intocapacitor-community:masterfrom
teja8352 wants to merge 1 commit intocapacitor-community:masterfrom
Conversation
… was not identified.
andreimuha-ionic
requested changes
Mar 26, 2026
Collaborator
andreimuha-ionic
left a comment
andreimuha-ionic
left a comment
There was a problem hiding this comment.
Hello @teja8352 .
I see an issue in the current checkSuBinary() implementation:
the list now includes common system directories (/system/, /system/bin/, /data/local/, /sbin/, /system/xbin/, etc.).
Since the check uses new File(path).exists(), this can return true on non-rooted devices and cause false positives.
For SU detection, it’s better to keep only specific root artifacts (files like .../su, Superuser.apk, and specific Magisk indicators), not base directories.
I suggest removing directory paths and adding tests for clean/rooted scenarios (including Magisk).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SU paths for root validation checks.
Issue Found: Magisk rooting was not identified.