Merged
Conversation
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
5 times, most recently
from
1e8faaf to
28a8749
Compare
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
2 times, most recently
from
4b89e1b to
106ee37
Compare
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
10 times, most recently
from
0574c08 to
08840a9
Compare
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
from
08840a9 to
036fa3f
Compare
andreynering
changed the title
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
from
036fa3f to
f69082a
Compare
| Project: g.options.project, | ||
| Location: g.options.location, | ||
| } | ||
| if g.options.skipAuth { |
Member
Author
There was a problem hiding this comment.
When running tests, specially when gcloud is not installed or configured, we need to skip authorization completely, because otherwise the internal SDKs will try to authenticate with gcloud and fail, and the tests themselves will fail. That means that the tests would always fail on CI, for example.
You made me realize that we might need to do a small adjustment here: we do need authorization to happen when recording, but we still need it to skip when just reproducing the VCRs.
Member
Author
There was a problem hiding this comment.
Just pushed a commit with a fix.
andreynering
force-pushed
the
charm-602-google-vertex-ai-initial-implementation
branch
from
482cf12 to
1b8c6c6
Compare
andreynering
deleted the
charm-602-google-vertex-ai-initial-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Google Vertex AI.
We're using the Google SDK for Gemini models and the Anthropic SDKs for Claude models. I had to do fixes on both to make it work properly for us.
While those are in review, I pushed the changes on an extra
fantasybranch so we can import from this project.On testing, ensure to use
us-east5region, because not all regions support Anthropic calls. It returns a generic 500 error if you try a not supported region.