Add thinking effort to the Anthropic provider#147
Add thinking effort to the Anthropic provider#147andreynering merged 3 commits intocharmbracelet:mainfrom
Conversation
|
Hey @kylecarbs, FYI, the fixes we made on the fork were done on the It's a good reminder to revisit that, tho. I made these fixes at the time and never checked if these are still needed in the new version nor I updated the fork. |
|
Thanks for the quick response @andreynering. My bad - shoulda checked the ref. Would it be alright if I submitted a PR updating that branch on the fork then? Seems much safer than pinning to main here and merging a change. |
|
@kylecarbs Yes. Let's do that in steps: update the fork first and add reasoning effort in a separate PR. |
|
FYI, I submitted PRs to upstream at the time, but they simply never reviewed them. |
|
PR here: charmbracelet/anthropic-sdk-go#1. Just doing some testing. |
e776cf2 to
5a87b67
Compare
The `fantasy` branch was updated from upstream. See: * charmbracelet/anthropic-sdk-go#1 * #147
The `fantasy` branch was updated from upstream. See: * charmbracelet/anthropic-sdk-go#1 * #147
|
@kylecarbs I pushed the update to Also, I'd just like to understand your motivation to add reasoning effort. I'm reading the docs and looks like this + adaptive thinking replaces Do you want this on Crush on you're using Fantasy yourself? Also, Anthropic models or another Anthropic-compatible API? |
|
@andreynering updated! I'm using Fantasy myself - lovely library y'all have made. We're using Anthropic models directly. |
|
@kylecarbs There is a failing test. Otherwise, it looks good! |
|
@andreynering fixing now! |
|
@andreynering should be good now, also rebased on main. |
|
@kylecarbs Still failing: |
|
@andreynering should be fixed now, sorry about that! |
andreynering
left a comment
There was a problem hiding this comment.
Hi @kylecarbs!
I made some changes to this PR, mostly cosmetical.
The most relevant behavior change is that I removed the enum validation because I prefer to let the API handle it.
I also opened two PRs on Catwalk and Crush to make this usable in Crush:
Thanks for your contribution! This all should be shipped still today.
CONTRIBUTING.md.This changes Fantasy to use the upstream Anthropic Go SDK rather than the Charm fork. There seemed to be no differences in the versions, other than it being slightly behind main (80 commits at the time of writing).